Adding a root filesystem override for kubelet mounter #35652

vishh · 2016-10-26T21:03:43Z

This is necessary to get hostPath volumes to work with containerized kubelet mounter

This change is

mtaufen

Can you add the reason for this new flag/mounter parameter to the commit message body?

mtaufen · 2016-10-26T21:38:17Z

hack/verify-flags/known-flags.txt

@@ -187,6 +187,8 @@ exit-on-lock-contention
 experimental-allowed-unsafe-sysctls
 experimental-bootstrap-kubeconfig
 experimental-keystone-url
+experimental-mounter-path


Removing this line will reduce your potential rebase burden, as this PR still relies on mounter-path and you already added experimental-mounter-path to known flags in #35646

jingxu97 · 2016-10-26T21:49:27Z

pkg/util/mount/mount_linux.go

@@ -64,13 +66,13 @@ type Mounter struct {
 func (mounter *Mounter) Mount(source string, target string, fstype string, options []string) error {
 	bind, bindRemountOpts := isBind(options)
 	if bind {
-		err := doMount(mounter.mounterPath, source, target, fstype, []string{"bind"})
+		err := doMount(mounter.mounterPath, path.Join(mounter.mounterRootfsPath, source), target, fstype, []string{"bind"})


I might miss something here, but source is already an absolute path?

source is already an absolute path in the native namespace. But from within the container, all native (root fs) paths have to be relative to the mounterRootfsPath.

jingxu97 · 2016-10-26T21:49:30Z

pkg/util/mount/mount.go

 	return &Mounter{
-		mounterPath: mounterPath,
+		mounterPath:       mounterPath,
+		mounterRootfsPath: mounterRootfsPath,


Could you explain why this mounterRootfsPath is needed? how it works?

/ to kubelet is /rootfs to the mounter container. So if kubelet wants to mount /foo/bar, then it has to pass /rootfs/foo/bar to the container.

Is that ok to put some comments about this somewhere in the code?

mtaufen · 2016-10-26T22:00:16Z

LGTM

jingxu97 · 2016-10-26T22:25:18Z

LGTM

vishh · 2016-10-26T23:07:00Z

Bumping priority since this is blocking 2 other PRs which have to go in asap for v1.4.x patch release

vishh · 2016-10-27T00:18:44Z

This PR needs more work. Will pick it up tomorrow.

vishh · 2016-10-27T04:42:31Z

Ok. I have fixed the issues with this PR.

This is useful for supporting hostPath volumes via containerized mounters in kubelet. Signed-off-by: Vishnu kannan <vishnuk@google.com>

k8s-github-robot · 2016-10-27T06:15:09Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-github-robot · 2016-10-27T06:58:58Z

Automatic merge from submit-queue

Automatic merge from submit-queue Update GCI mounter script to run in a rkt container Depends on #35652

@vishh

Automatic merge from submit-queue Fixes PR #35652 This is breaking the build. Fixes #35564 /cc @vishh @sjenning Fixes PR #35652

#35717-origin-release-1.4 Automatic merge from submit-queue Automated cherry pick of #35721 #35717 Cherry pick of #35721 #35717 on release-1.4. #35721: Fixes PR #35652 #35717: update rkt to v1.18.0 which avoids outputting debug

@jingxu97

Automatic merge from submit-queue [Kubelet] Use the custom mounter script for Nfs and Glusterfs only This patch reduces the scope for the containerized mounter to NFS and GlusterFS on GCE + GCI clusters This patch also enabled the containerized mounter on GCI nodes Shepherding multiple PRs through the submit queue is painful. Hence I combined them into this PR. Please review each commit individually. cc @jingxu97 @saad-ali #35652 has also been reverted as part of this PR

…ck-of-#35721-kubernetes#35717-origin-release-1.4 Automatic merge from submit-queue Automated cherry pick of kubernetes#35721 kubernetes#35717 Cherry pick of kubernetes#35721 kubernetes#35717 on release-1.4. kubernetes#35721: Fixes PR kubernetes#35652 kubernetes#35717: update rkt to v1.18.0 which avoids outputting debug

@jingxu97

Automatic merge from submit-queue [Kubelet] Use the custom mounter script for Nfs and Glusterfs only This patch reduces the scope for the containerized mounter to NFS and GlusterFS on GCE + GCI clusters This patch also enabled the containerized mounter on GCI nodes Shepherding multiple PRs through the submit queue is painful. Hence I combined them into this PR. Please review each commit individually. cc @jingxu97 @saad-ali kubernetes/kubernetes#35652 has also been reverted as part of this PR

@jingxu97

Automatic merge from submit-queue [Kubelet] Use the custom mounter script for Nfs and Glusterfs only This patch reduces the scope for the containerized mounter to NFS and GlusterFS on GCE + GCI clusters This patch also enabled the containerized mounter on GCI nodes Shepherding multiple PRs through the submit queue is painful. Hence I combined them into this PR. Please review each commit individually. cc @jingxu97 @saad-ali kubernetes/kubernetes#35652 has also been reverted as part of this PR

@jingxu97

Automatic merge from submit-queue [Kubelet] Use the custom mounter script for Nfs and Glusterfs only This patch reduces the scope for the containerized mounter to NFS and GlusterFS on GCE + GCI clusters This patch also enabled the containerized mounter on GCI nodes Shepherding multiple PRs through the submit queue is painful. Hence I combined them into this PR. Please review each commit individually. cc @jingxu97 @saad-ali kubernetes/kubernetes#35652 has also been reverted as part of this PR

…ootfs Automatic merge from submit-queue Adding a root filesystem override for kubelet mounter This is necessary to get hostPath volumes to work with containerized kubelet mounter

vishh added priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. labels Oct 26, 2016

vishh added this to the v1.4 milestone Oct 26, 2016

vishh assigned jingxu97 Oct 26, 2016

googlebot added the cla: yes label Oct 26, 2016

k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 26, 2016

vishh mentioned this pull request Oct 26, 2016

Update GCI mounter script to run in a rkt container #35349

Merged

vishh assigned mtaufen Oct 26, 2016

mtaufen reviewed Oct 26, 2016

View reviewed changes

vishh force-pushed the klet-overrride-mount-rootfs branch from 72ded47 to d17d01d Compare October 26, 2016 21:47

jingxu97 reviewed Oct 26, 2016

View reviewed changes

vishh force-pushed the klet-overrride-mount-rootfs branch from d17d01d to c96aa14 Compare October 26, 2016 22:21

jingxu97 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2016

vishh added lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Oct 26, 2016

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2016

vishh removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2016

vishh force-pushed the klet-overrride-mount-rootfs branch from c96aa14 to 0446784 Compare October 27, 2016 04:41

vishh removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Oct 27, 2016

Adding a root filesystem override for kubelet mounter

e861a57

This is useful for supporting hostPath volumes via containerized mounters in kubelet. Signed-off-by: Vishnu kannan <vishnuk@google.com>

vishh force-pushed the klet-overrride-mount-rootfs branch from 0446784 to e861a57 Compare October 27, 2016 04:43

vishh added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 27, 2016

k8s-github-robot merged commit 69b214d into kubernetes:master Oct 27, 2016

sjenning mentioned this pull request Oct 27, 2016

mounting nfs volumes in pods is broken #35718

Closed

pires added a commit to apprenda/kubernetes that referenced this pull request Oct 27, 2016

Fixes PR kubernetes#35652

01adb46

k8s-github-robot pushed a commit that referenced this pull request Oct 27, 2016

Merge pull request #35349 from vishh/gci-cmount

90f4cee

Automatic merge from submit-queue Update GCI mounter script to run in a rkt container Depends on #35652

rmmh mentioned this pull request Oct 27, 2016

kubernetes-cross-build: broken test run #35564

Closed

pires mentioned this pull request Oct 27, 2016

Fixes PR #35652 #35721

Merged

jessfraz added cherrypick-candidate cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Oct 27, 2016

k8s-github-robot pushed a commit that referenced this pull request Oct 27, 2016

Merge pull request #35721 from apprenda/fix_mounter_struct

9302dcb

Automatic merge from submit-queue Fixes PR #35652 This is breaking the build. Fixes #35564 /cc @vishh @sjenning Fixes PR #35652

jessfraz mentioned this pull request Oct 28, 2016

Automated cherry pick of #35721 #35717 #35804

Merged

jessfraz pushed a commit to jessfraz/kubernetes that referenced this pull request Oct 28, 2016

Fixes PR kubernetes#35652

92bc986

jessfraz mentioned this pull request Oct 28, 2016

Cherry picking "mounter" patches on release-1.4 #35809

Closed

jessfraz removed cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate labels Oct 28, 2016

luxas mentioned this pull request Oct 28, 2016

Make kubernetes-cross-build SQ-blocking kubernetes/test-infra#951

Closed

vishh mentioned this pull request Oct 28, 2016

[Kubelet] Use the custom mounter script for Nfs and Glusterfs only #35821

Merged

dchen1107 mentioned this pull request Oct 31, 2016

Node E2E is failing on GCI #35935

Closed

shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016

Fixes PR kubernetes#35652

a63daf2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding a root filesystem override for kubelet mounter #35652

Adding a root filesystem override for kubelet mounter #35652

vishh commented Oct 26, 2016 •

edited by k8s-oncall

mtaufen left a comment •

edited

mtaufen Oct 26, 2016

vishh Oct 26, 2016

jingxu97 Oct 26, 2016

vishh Oct 26, 2016

jingxu97 Oct 26, 2016

vishh Oct 26, 2016

jingxu97 Oct 26, 2016

vishh Oct 26, 2016

vishh Oct 26, 2016

mtaufen commented Oct 26, 2016

jingxu97 commented Oct 26, 2016

vishh commented Oct 26, 2016

vishh commented Oct 27, 2016

vishh commented Oct 27, 2016

k8s-github-robot commented Oct 27, 2016

k8s-github-robot commented Oct 27, 2016

Adding a root filesystem override for kubelet mounter #35652

Adding a root filesystem override for kubelet mounter #35652

Conversation

vishh commented Oct 26, 2016 • edited by k8s-oncall

mtaufen left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mtaufen commented Oct 26, 2016

jingxu97 commented Oct 26, 2016

vishh commented Oct 26, 2016

vishh commented Oct 27, 2016

vishh commented Oct 27, 2016

k8s-github-robot commented Oct 27, 2016

k8s-github-robot commented Oct 27, 2016

vishh commented Oct 26, 2016 •

edited by k8s-oncall

mtaufen left a comment •

edited